Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-460: Allow editing of URL alias for News, Events, Peopple #470

Open
wants to merge 3 commits into
base: 4.x
Choose a base branch
from

Conversation

buttonwillowsix
Copy link
Contributor

READY FOR REVIEW

Summary

  • Woods, Precourt, and sometimes the School site need to be able to edit their URL aliases

Review By (Date)

  • August

Criticality

  • HIGH

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Try to edit an event, news, or person
  3. Try to edit the alias
  4. Profit!

Front End Validation

No front-end impact to this PR

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • SDSS Stack

Associated Issues and/or People

  • SDSS-460

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant