SDSS-1313: Consolidated stanford_profile_helper into the sdss_profile (…

…#489)

* Consolidated stanford_profile_helper into the sdss_profile.

composer.json

@@ -186,7 +186,6 @@
         "su-sws/stanford_fields": "^8.2",
         "su-sws/stanford_media": "^11.0",
         "su-sws/stanford_migrate": "^8.3",
-        "su-sws/stanford_profile_helper": "^9.6",
         "su-sws/stanford_samlauth": "^1.0",
         "su-sws/stanford_syndication": "^1.0"
     },
@@ -384,9 +383,6 @@
             },
             "drupal/webp": {
                 "https://www.drupal.org/project/webp/issues/3281606": "https://git.drupalcode.org/project/webp/-/merge_requests/33.patch"
-            },
-            "su-sws/stanford_profile_helper": {
-                "Remove paragraph layout restrictions from stanford_layout_paragraphs": "patches/stanford/stanford_layout_paragraphs.patch"
             }
         }
     },

docroot/profiles/sdss/sdss_profile/modules/stanford_profile_helper/.browserslistrc

@@ -0,0 +1,2 @@
+last 2 versions
+ie 11

docroot/profiles/sdss/sdss_profile/modules/stanford_profile_helper/.codeclimate.yml

@@ -0,0 +1,117 @@
+version: "2"
+checks:
+  argument-count:
+    enabled: false
+  method-complexity:
+    config:
+      threshold: 10
+
+plugins:
+  # https://docs.codeclimate.com/docs/eslint
+  # ES Linting requires an .eslintrc file to tweak checks.
+  eslint:
+    enabled: false
+  # We can ignore css since we compile all css from scss files.
+  csslint:
+    enabled: false
+  # We don't lint our coffee. Eew.
+  coffeelint:
+    enabled: false
+  # SASS Lint requires a .sass-lint.yml file in the repo in order to tweak settings.
+  # Withouth the .sass-lint.yml file it will run with the defaults.
+  # Defaults file: https://github.com/sasstools/sass-lint/blob/master/lib/config/sass-lint.yml
+  sass-lint:
+    enabled: true
+  # SCSS Lint requires a .scss-lint.yml file in the repo in order to tweak settings.
+  # Withouth the .scss-lint.yml file it will run with the defaults.
+  # Defaults file: https://github.com/brigade/scss-lint/blob/master/config/default.yml
+  scss-lint:
+    enabled: false
+  phpcodesniffer:
+    enabled: true
+    checks:
+      Drupal Commenting FunctionComment TypeHintMissing:
+        enabled: true
+      Drupal Commenting FunctionComment IncorrectTypeHint:
+        enabled: true
+      DrupalPractice Commenting CommentEmptyLine SpacingAfter:
+        enabled: true
+      Drupal NamingConventions ValidFunctionName ScopeNotCamelCaps:
+        enabled: true
+      Drupal NamingConventions ValidClassName StartWithCaptial:
+        enabled: false
+      Drupal NamingConventions ValidFunctionName NotCamelCaps:
+        enabled: false
+      DrupalPractice General ClassName ClassPrefix:
+        enabled: false
+      Drupal NamingConventions ValidClassName NoUnderscores:
+        enabled: true
+    config:
+      file_extensions: "php,inc,install,module,profile"
+      standard: "Drupal,DrupalPractice"
+  phpmd:
+    enabled: true
+    checks:
+      Design/WeightedMethodCount:
+        enabled: false
+      CleanCode/IfStatementAssignment:
+        enabled: false
+      CleanCode/ErrorControlOperator:
+        enabled: false
+      CleanCode/StaticAccess:
+        enabled: false
+      CleanCode/ElseExpression:
+        enabled: false
+      CleanCode/BooleanArgumentFlag:
+        enabled: false
+      UnusedFormalParameter:
+        enabled: false
+      Naming/ShortVariable:
+        enabled: false
+    config:
+      # https://phpmd.org/rules/index.html
+      # The following sets include everything except the controversial set.
+      # We can configure these further through .xml files. See docs.
+      rulesets: "cleancode,codesize,design,naming,unusedcode"
+      # Include special Drupal file extensions.
+      file_extensions: "inc,module,profile,php,install"
+  # https://docs.codeclimate.com/docs/phan
+  phan:
+    enabled: true
+    config:
+      target_php_version: 8.2
+      file_extensions: "php,module,profile,inc"
+      # minimum-severity: 1
+      ignore-undeclared: true
+      # quick: true
+      # backward-compatiility-checks: true
+      # dead-code-detection: true
+  # https://docs.codeclimate.com/docs/duplication
+  duplication:
+    enabled: true
+    # exclude_paths:
+    #   - examples/
+    config:
+      languages:
+        javascript:
+          mass_threshold: 50
+          # count_threshold: 3
+        php:
+          mass_threshold: 60
+  fixme:
+    enabled: true
+    config:
+      strings:
+        - FIXME
+        - BUG
+        - TODO
+        - todo
+        - dpm
+        - dsm
+# exclude these files/paths
+exclude_patterns:
+  - "tests/"
+  - "**.min.*"
+  - "**/Gruntfile.js"
+  - "**.min.*"
+  - "**/tests/**/*"

docroot/profiles/sdss/sdss_profile/modules/stanford_profile_helper/.eslintrc

@@ -0,0 +1,111 @@
+{
+  extends: "eslint:recommended",
+  env: {
+    browser: true,
+    es6: true
+  },
+  globals: {
+    domready: true
+  },
+  parserOptions: {
+    ecmaVersion: 6,
+    sourceType: "module",
+    ecmaFeatures: {
+      arrowFunctions: true,
+      blockBindings: true,
+      classes: true,
+      defaultParameters: true,
+      destructuring: true,
+      forOf: true,
+      generators: true,
+      objectLiteralComputedProperties: true,
+      objectLiteralDuplicateProperties: true,
+      objectLiteralShorthandMethods: true,
+      objectLiteralShorthandProperties: true,
+      regexUFlag: true,
+      regexYFlag: true,
+      restParams: true,
+      spread: true,
+      superInFunctions: true,
+      templateStrings: true,
+      unicodeCodePointEscapes: true,
+      globalReturn: true
+    }
+  },
+  rules: {
+    max-len: [2, 120, 2, {"ignoreUrls": true}],
+    array-bracket-spacing: [2, "never"],
+    block-scoped-var: 2,
+    brace-style: [2, "stroustrup", {"allowSingleLine": true}],
+    comma-dangle: [2, "never"],
+    comma-spacing: 2,
+    comma-style: [2, "last"],
+    computed-property-spacing: [2, "never"],
+    curly: [2, "all"],
+    eol-last: 2,
+    eqeqeq: [2, "smart"],
+    guard-for-in: 2,
+    indent: [2, 2, {"SwitchCase": 1}],
+    key-spacing: [2, {"beforeColon": false, "afterColon": true}],
+    keyword-spacing: [2, {"before": true, "after": true}],
+    linebreak-style: [2, "unix"],
+    lines-around-comment: [2, {"beforeBlockComment": true, "afterBlockComment": false}],
+    new-parens: 2,
+    no-array-constructor: 2,
+    no-caller: 2,
+    no-catch-shadow: 2,
+    no-eval: 2,
+    no-extend-native: 2,
+    no-extra-bind: 2,
+    no-extra-parens: [2, "functions"],
+    no-implied-eval: 2,
+    no-iterator: 2,
+    no-label-var: 2,
+    no-labels: 2,
+    no-lone-blocks: 2,
+    no-loop-func: 2,
+    no-multi-spaces: 2,
+    no-multi-str: 2,
+    no-native-reassign: 2,
+    no-nested-ternary: 2,
+    no-new-func: 2,
+    no-new-object: 2,
+    no-new-wrappers: 2,
+    no-octal-escape: 2,
+    no-process-exit: 2,
+    no-proto: 2,
+    no-return-assign: 2,
+    no-script-url: 2,
+    no-sequences: 2,
+    no-shadow-restricted-names: 2,
+    no-spaced-func: 2,
+    no-trailing-spaces: 2,
+    no-undef-init: 2,
+    no-undefined: 2,
+    no-unused-expressions: 2,
+    no-unused-vars: [2, {"vars": "all", "args": "none"}],
+    no-with: 2,
+    object-curly-spacing: [2, "never"],
+    one-var: [2, "never"],
+    quote-props: [2, "consistent-as-needed"],
+    quotes: [2, "single", "avoid-escape"],
+    semi: [2, "always"],
+    semi-spacing: [2, {"before": false, "after": true}],
+    space-before-blocks: [2, "always"],
+    space-before-function-paren: [2, {"anonymous": "always", "named": "never"}],
+    space-in-parens: [2, "never"],
+    space-infix-ops: 2,
+    space-unary-ops: [2, { "words": true, "nonwords": false }],
+    spaced-comment: [2, "always"],
+    strict: [2, "function"],
+    yoda: [2, "never"],
+    max-nested-callbacks: [1, 3],
+    valid-jsdoc: [1, {
+      prefer: {
+        returns: "return",
+        property: "prop"
+      },
+      requireReturn: false
+    }]
+  }
+}

docroot/profiles/sdss/sdss_profile/modules/stanford_profile_helper/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,35 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.