-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5905: Rework social media footer (backend) #1662
Open
codechefmarc
wants to merge
19
commits into
11.5.1-release
Choose a base branch
from
SHS-5905--social-block
base: 11.5.1-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a9075a7
feat(SHS-5905): Recreate social media block as a custom block plugin
codechefmarc bc77b70
feat(SHS-5905): Add composer.lock
codechefmarc 3f7823a
feat(SHS-5905): Enable multivalue form element module
codechefmarc 3aac4af
feat(SHS-5905): Add update hook for permissions change
codechefmarc dcd08ed
fix(SHS-5905): Fix error for default config and add cache context for…
codechefmarc 7d42637
fix(SHS-5905): Contextual menu still not rendering on Tugboat for non…
codechefmarc 8df9eed
fix(SHS-5905): Fix attached library for contextual menu
codechefmarc 69960f0
Merge branch '11.4.1-release' into SHS-5905--social-block
codechefmarc c0822b8
fix(SHS-5909): Strict checking of the array seemed to fix the context…
codechefmarc 3a31d71
Merge branch '11.4.1-release' into SHS-5905--social-block
codechefmarc ba88271
fix(SHS-5905): Remove strict checking
codechefmarc e219687
fix(SHS-5905): Remove old permissions before adding social media bloc…
codechefmarc d2c1c21
fix(SHS-5905): Linting fixes
codechefmarc ec99c5d
chore(SHS-5905): WIP TEST ONLY - see if removing the code block in th…
codechefmarc 510737e
fix(SHS-5905): Fix contextual menu for non-admins
codechefmarc 69dc3aa
Merge branch '11.5.1-release' into SHS-5905--social-block
codechefmarc f0374da
feat(SHS-5905): Remove permission update hook and add dependency on o…
codechefmarc 0a94aff
Merge branch '11.5.1-release' of github.com:SU-HSDO/suhumsci into SHS…
cienvaras fc6d2a9
feat(shs-5906): icon logic, templates and styles for social media foo…
cienvaras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
edit social media block: | ||
title: 'Edit social media block' | ||
description: 'Allows users to configure the social media block' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're changing here a lot of permission unrelated to the block itself, please update to include only the necessary permissions.