-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5811: Add logout button to sites #1641
base: develop
Are you sure you want to change the base?
Conversation
…date existing blocks to add logout text
@joegl - Adding you in here for review. Other PR for the forked repo is here: SU-SWS/stanford_samlauth#21 |
@joegl I added a comment - SU-SWS/stanford_samlauth#21 (comment) on the stanford_samlauth PR. There was a comment that we needed clarification on: Since this is a "Login Block", it think it would be better to use a new block plugin. @codechefmarc wasn't sure if this meant he needed to create a new block for logout as the original plan was to do everything in that block plugin. I didn't know if it was more of a naming convention issue or a best practice/functionality issue. If the functionality works could updating the naming of the block to |
Update from Mike - We can change the name of the file & class but, it's not an option to change the ID of the block plugin. This would cause cascading issues on every platform that uses the module and block. |
@cienvaras - Updated this PR with the latest code to split the logout block into its own plugin and ready for review. |
READY FOR REVIEW
Summary
composer.json
change for adding a forked version of thestanford_samlauth
module that adds logout button functionality. (This change needs to be reverted before merge!)Need Review By (Date)
2024-09-07
Urgency
low
Steps to Test
/admin/structure/block
PR Checklist