-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radium dataflow rendering #1018
Draft
MathiasPaulin
wants to merge
239
commits into
STORM-IRIT:release-candidate
Choose a base branch
from
MathiasPaulin:Radium-dataflow-rendering
base: release-candidate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Radium dataflow rendering #1018
MathiasPaulin
wants to merge
239
commits into
STORM-IRIT:release-candidate
from
MathiasPaulin:Radium-dataflow-rendering
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
from
November 4, 2022 16:58
0c6ebf3
to
f96c562
Compare
Codecov Report
@@ Coverage Diff @@
## release-candidate #1018 +/- ##
=====================================================
+ Coverage 45.65% 46.81% +1.15%
=====================================================
Files 312 390 +78
Lines 23060 27333 +4273
=====================================================
+ Hits 10529 12797 +2268
- Misses 12531 14536 +2005
|
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
4 times, most recently
from
November 8, 2022 13:57
229b972
to
c1d4d3f
Compare
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
12 times, most recently
from
February 6, 2023 13:59
c6d82fc
to
1e73305
Compare
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
2 times, most recently
from
February 13, 2023 16:13
adc30c9
to
3948560
Compare
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
3 times, most recently
from
February 27, 2023 11:26
1e2be62
to
25142de
Compare
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
3 times, most recently
from
March 24, 2023 07:51
50a585c
to
d27d5d7
Compare
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
4 times, most recently
from
April 4, 2023 11:34
8c23496
to
14d958f
Compare
MathiasPaulin
force-pushed
the
Radium-dataflow-rendering
branch
from
June 30, 2023 09:26
a5c5284
to
66c36f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is a draft for Node base rendering in Radium.
It extends the PR #1007 with dedicated nodes for rendering and a new type of renderer.
This PR will be rebased (and then force pushed) on any changes in PR #1007
Note that this PR only adds 17 files to the PR #1007 (whose number of files should decrease by removing examples duplicated in unittests)
This PR is stills draft as under heavy work (porting from prototype to the PR)
Right now, the system is quite fonctionning with only a few rendering nodes available
TODO