Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HPX_WITH_FETCH_BOOST #6511

Closed
wants to merge 1 commit into from
Closed

Fix HPX_WITH_FETCH_BOOST #6511

wants to merge 1 commit into from

Conversation

Pansysk75
Copy link
Member

Fixes following issues when HPX_WITH_FETCH_BOOST=ON:

  • Boost being re-fetched on projects that would depend on HPX.
  • Boost not compiling necessary libraries when a non header-only instance of Boost was needed

Now when HPX_WITH_FETCH_BOOST=ON Boost will be installed alongside HPX.

To fix:

  • Duplicated code for figuring out which Boost libraries are needed
  • Make hpx_boost_root-install.cmake contain relative path instead of absolute(?)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.10%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d08354d) 222123 188895 85.04%
Head commit (0e1fe2d) 191114 (-31009) 162717 (-26178) 85.14% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6511) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@srinivasyadav18
Copy link
Contributor

/retest lsu

@srinivasyadav18
Copy link
Contributor

/retest

@hkaiser
Copy link
Member

hkaiser commented Nov 2, 2024

@Pansysk75 could you rebase this onto master to resolve the conflicts, please?

@Pansysk75
Copy link
Member Author

@Pansysk75 could you rebase this onto master to resolve the conflicts, please?

This PR should be discarded in favor of #6510.

@hkaiser hkaiser marked this pull request as ready for review November 2, 2024 16:57
@hkaiser hkaiser self-requested a review as a code owner November 2, 2024 16:57
@hkaiser hkaiser closed this Nov 2, 2024
@hkaiser hkaiser deleted the fetch-boost-fix branch November 2, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants