Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert bad links filter #704

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Invert bad links filter #704

merged 1 commit into from
Oct 18, 2023

Conversation

zacharykeeping
Copy link
Member

I noticed the logic here is backwards and is reporting all good links as bad links, so this inverts it.

@zacharykeeping zacharykeeping marked this pull request as ready for review October 18, 2023 04:53
tombui99
tombui99 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@tombui99 tombui99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopss that's my bad.. Thanks for the fix!

@tombui99 tombui99 changed the base branch from staging to main October 18, 2023 05:02
@tombui99 tombui99 merged commit b7b6e9c into main Oct 18, 2023
1 check passed
@tombui99 tombui99 temporarily deployed to Staging October 18, 2023 23:03 — with GitHub Actions Inactive
@tombui99 tombui99 deleted the fix-statuscode branch October 23, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombui99 tombui99 tombui99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharykeeping @tombui99