doc: improve description of ldap_disable_range_retrieval #7806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit-bose
reviewed
Jan 21, 2025
src/man/sssd-ldap.5.xml
Outdated
| groups will appear as having no members. | ||
| groups will appear as having no members. To retrieve | ||
| all members of a group, you must increase | ||
| the MaxValRange setting in Active Directory. |
There was a problem hiding this comment.
Hi,
I think it would be better to be a bit more explicit and maybe start a new paragraph which starts with something like "This option does not enable reading subsequent ranges and the maximal number of members in a group will still be given by MaxValRange. To retrieve ...."
bye,
Sumit
There was a problem hiding this comment.
Hi Sumit, thank you. I agree with you. This should be explicitly mentioned. I updated the description.
domiborges
force-pushed
the
man_ldap_disable_range_retrieval_review
branch
from
e0025f8 to
91d2aa6
Compare
justin-stephenson
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the description of the
ldap_disable_range_retrievaloption to clarify the how to get a full group member list when groups exceed 1500 members.