Allow multiple services associated to the same port #7790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplopez
reviewed
Jan 13, 2025
aplopez
reviewed
Jan 13, 2025
RFC6335 Section 5 allows more than one service associated with a particular port. In this case always return the first result returned by sysdb_getservbyport(). Signed-off-by: Samuel Cabrero <[email protected]>
Signed-off-by: Samuel Cabrero <[email protected]>
RFC6335 section 5 allow multiple services associated to the same transport and port. This commit allows storing multiple service entries in the cache for the same port and the lookup functions will return all matching entries. The cache_req plugin will pick the first result. Signed-off-by: Samuel Cabrero <[email protected]>
Signed-off-by: Samuel Cabrero <[email protected]>
scabrero
force-pushed
the
rfc6335-services
branch
from
c35f648 to
48c2de6
Compare
pbrezina
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you, ack.
We are currently trying to get rid of intg tests and we are converting them to tests/system. Would you like to convert it yourself as part of this pull request? It may however be little bit more complicated as it needs some new bits in https://github.com/SSSD/sssd-test-framework
I am fine approving it as is though.
|
Pushed PR: #7790
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the backend has multiple services are associated to the same port then concurrent NSS lookups fail.
Example:
RFC6335 Section 5 allows more than one service associated with a particular port, but
sysdb_store_service()does not and replaces the previously cached entries for that port, causing the NSS queries to fail.This MR allows storing multiple entries for the same port, returning only the first result on service-by-port lookup.