-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authentication: Add different auth methods for passkey #112
Conversation
madhuriupadhye
commented
Jul 8, 2024
•
edited
Loading
edited
5e570af
to
ba6e79b
Compare
Finally it worked, INFO 2024-08-01 21:43:39,778 client.test Previous command completed with exit code 0
|
d1a67e9
to
dcc6ad5
Compare
a3c99a6
to
b65ca62
Compare
c265c7d
to
4856bbd
Compare
26ffded
to
ea96500
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 failures
lint-upstream: commands[0]> flake8 sssd_test_framework tests
sssd_test_framework/utils/authentication.py:26:1: E302 expected 2 blank lines, found 1
sssd_test_framework/utils/authentication.py:36:1: E302 expected 2 blank lines, found 1
sssd_test_framework/utils/authentication.py:355:87: W291 trailing whitespace
sssd_test_framework/utils/authentication.py:455:1: W293 blank line contains whitespace
sssd_test_framework/utils/authentication.py:461:106: W291 trailing whitespace
sssd_test_framework/utils/authentication.py:483:87: W291 trailing whitespace
sssd_test_framework/utils/authentication.py:484:100: W291 trailing whitespace
sssd_test_framework/utils/authentication.py:536:120: E501 line too long (141 > 119 characters)
Needs fixing the pep8, otherwise LGTM. My other comment is just a suggestion. |
bb7afed
to
ea8eddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix PEP8 and it is good to go.
Add following authentication methods 1. Passkey with pin (default) 2. Passkey with pin and interactive and touch prompts 3. Passkey wihout pin with both prompts 4. Passkey auth when we press enter for pin and it goes to next auth method as a password Signed-off-by: Madhuri Upadhye <[email protected]>
2a62b59