[FEAT] 프로그래스바 컴포넌트 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🪷 Storybook 확인 🪷 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Taew00k
reviewed
Jan 14, 2025
| <div className={ProgressBarStyle.barContainer}> | ||
| <div | ||
| className={ProgressBarStyle.barStyle} | ||
| style={{ width: `${progressPercentage}%` }}></div> |
There was a problem hiding this comment.
컨벤션에서 인라인 스타일은 사용하지 않기로 했으니 recipe를 사용해서 currentStep에 맞게 width를 설정하는 방법은 어떨까요?
Taew00k
approved these changes
Jan 14, 2025
seong-hui
approved these changes
Jan 14, 2025
| <div className={ProgressBarStyle.barContainer}> | ||
| <div | ||
| className={ProgressBarStyle.barStyle} | ||
| style={{ width: `${progressPercentage}%` }}></div> |
There was a problem hiding this comment.
현재 단계의 진행도를 계산해서 퍼센트로 width를 채우는 방식 넘 좋네요! inline스타일을 사용하지 않고 적용할 수 있는 방법이 있는지에 대해서 고민하는 시간을 가져봐도 좋을 것 같아요! 물론 지금 progressPercentage를 통해 inline으로 width를 적용하는 것도 좋은 것 같아요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ 관련 이슈
🧑💻 작업 내용
🗯️ PR 포인트
assignInlineVars라는게 있는 것 같은데 좀더 복잡하기도 하고 현재 인라인 스타일도 명확하게 표현되는 것 같아 수정하지는 않았습니다. 추후 퍼널구조를 적용하면서 수정될 수도 있을 부분이라 생각되어 추후에 다시 생각해보는걸로 남기겠습니다!🚀 알게된 점
📖 참고 자료 (선택)
📸 스크린샷 (선택)