[FEAT] 페이지 버튼 공통 컴포넌트 구현 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🪷 Storybook 확인 🪷 |
seong-hui
approved these changes
Jan 13, 2025
| import pageBtnStyles from './pageBtn.css'; | ||
|
|
||
| interface PageBtnProps { | ||
| pageNum: number; |
There was a problem hiding this comment.
pageIndex 처럼 네이밍을 하면 더욱 이해하기 쉬울 것 같습니당!
maylh
approved these changes
Jan 13, 2025
src/stories/pageBtn.stories.ts
Outdated
| } | ||
|
|
||
| const meta: Meta<typeof PageBtn> = { | ||
| title: 'Common/PageBtn', // 스토리북에서 표시될 경로 |
There was a problem hiding this comment.
주석은 지워주셔도 될 것 같고, 스토리북 경로도 Common/Button/PageBtn 으로 수정하면 좋을 것 같습니다 ~~~!!!
bykbyk0401
approved these changes
Jan 13, 2025
| @@ -0,0 +1,23 @@ | |||
| import theme from '@styles/theme.css'; | |||
| import { styleVariants } from '@vanilla-extract/css'; | |||
There was a problem hiding this comment.
recipe말고 styleVariants로도 다양한 variants를 가진 스타일을 잘 적용해주신 것 같아요!
새로운 방법도 알게 되어서 좋네요 :)
덕분에 단일 스타일에 대해 정의하는 style과 styleVariants의 차이점에 대해서도 알아보았습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ 관련 이슈
🧑💻 작업 내용
🗯️ PR 포인트
🚀 알게된 점
📖 참고 자료 (선택)
📸 스크린샷 (선택)
현재 페이지인 경우
현재 페이지가 아닌 경우
