-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 탐색 페이지 검색바 구현 #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니당 ㅎㅎ 코멘트 한번만 확인 해주세요!
return ( | ||
<Flex align="center" width="29.9rem" height="4.4rem" position="relative" margin="0 0 0 1.2rem"> | ||
<IcSearchGray className={searchGrayStyle} width={24} onClick={handleSearchIconClick} /> | ||
<Input | ||
isSearch={true} | ||
ref={ref} | ||
value={searchValue} | ||
placeholder="장르나 댄서 네임을 검색해 보세요" | ||
onChange={handleInputChange} | ||
/> | ||
<IcXCircleGray className={xCircleGrayStyle} width={24} onClick={handleClearInput} /> | ||
</Flex> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 Flex에 margin="0 0 0 1.2rem"
marginLeft 속성도 있어서 그냥 marginLeft="1.2rem"
으로 해도 될 것 같아요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 Flex에
margin="0 0 0 1.2rem"
marginLeft 속성도 있어서 그냥marginLeft="1.2rem"
으로 해도 될 것 같아요~
해당 작업을 한 브랜치는 아직 Flex
컴포넌트에서 marginLeft
의 속성이 적용되기 전이여서 추후에 수정하겠습니다.
|
||
SearchBar.displayName = 'SearchBar'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 확인한번 해주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 확인한번 해주세요!
불필요한 코드 삭제했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 코멘트 하나만 확인해주세요~!
|
||
top: 0, | ||
bottom: 0, | ||
left: 16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 top과 bottom이 동시에 있는 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 top과 bottom이 동시에 있는 이유가 있나요?
불필요한 코드 삭제했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공통 Input에 Icon을 추가하는 것이 쉽지 않았을 것 같은데 이렇게 absolute
로 추가하는 방법도 나쁘지 않은 것 같습니다! 사실 공통 컴포넌트에 Icon을 분기해야 하는지 고민이 되었는데 이렇게 하는 것도 좋은 것 같습니다!
이후에 확장이 더 된다면 다시 이 부분 생각해봐요!
📌 Related Issues
✅ 체크 리스트
📄 Tasks
⭐ PR Point (To Reviewer)
search/index.tsx
추후에 검색바 인풋 내용(searchValue)을 검색 아이콘을 클릭하면 api post 요청을 보내야하기 때문에
console.log(searchValue);
로 임의로 작성해놓았습니다.📷 Screenshot
🔔 ETC