-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#24] 바텀시트 컴포넌트 구현 #42
Conversation
# Conflicts: # app/build.gradle.kts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
필수로 해야하는 것은 없고 한번씩 검토 후 확인해주세요 :)
sheetState: BottomSheetScaffoldState<AdvancedSheetState>, | ||
sheetContent: @Composable () -> Unit, | ||
modifier: Modifier = Modifier, | ||
dragHandle: @Composable () -> Unit = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3) 말씀해주신 대로 handle 자체도 변경될 수 있기에 디폴트 값을 넣어두되, 빼두는게 좋을 것 같습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
캬~ 바로 분리하겠습니다ㅎㅎ
build.gradle.kts
Outdated
maven( | ||
url = uri("https://dl.google.com/dl/android/maven2") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5) 저는 어제 테스트할 때 메이븐 추가 안했어도 됐었는데 한번만 확인 부탁드릴게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 헐 제가 어제 할 때 안돼서 넣었던건데 지금 하니까 또 없이도 잘 되네요..?? 바로 삭제하겠습니다ㅎㅎ 감사해요!!
enum class AdvancedSheetState { | ||
Hidden, | ||
PartiallyExpanded, | ||
Expanded | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p4) 저희 State상으로 Hidden
되는 경우는 없는 것 같습니다!
Collapse
는 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오오오오 너무 좋은 생각인데요?? 기존에 있는 state는 hidden이라 그대로 만들었는데 현재 저희 바텀시트에서는 collapsed라고 하는게 맞네요!! 감사합니다😊
|
||
@OptIn(ExperimentalMaterial3Api::class) | ||
@Composable | ||
fun FixedBottomSheet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5) 이건 EmtpyView에서 사용하는 움직이지 않는 바텀시트인가요??
하나의 바텀시트에서 PartiallyExpanded
상태로 한 후 스크롤 락 거는 방법이 있는지 한번 찾아보면 좋을 것 같습니다!
상태에 따라 BottomSheetScaffold 자체를 변경한다면 너무 큰 오버헤드가 생길 것 같아요.
최악의 경우에는 지도가 깜빡일수도..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컴포넌트 두개 합치기 성공!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
최고최고 고생많으셨습니다! 결국 찾으셨네요! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~🚀
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_Recording_20250116_093059_Spoony-Android.mp4
Uncompleted Tasks 😅
N/A
To Reviewers 📢