Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#39] 신고하기 페이지 ReportRadioButton 컴포넌트 구현 #40

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

Roel4990
Copy link
Member

Related issue 🛠

Work Description ✏️

  • 신고하기 페이지 ReportRadioButton 컴포넌트 구현

Screenshot 📸

image

To Reviewers 📢

디쌤들과 협의해서 기본 RadioButton 사용하기로 했습니다! 실 디자인과 조금 다를 수 있어요! 감안해주세요!

@Roel4990 Roel4990 added 🧡세홍🧡 🧡세홍🧡 FEAT✨ 새로운 기능 구현 labels Jan 15, 2025
@Roel4990 Roel4990 self-assigned this Jan 15, 2025
@Roel4990 Roel4990 requested a review from a team as a code owner January 15, 2025 19:34
@Roel4990 Roel4990 linked an issue Jan 15, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오~~~ 수고하셨습니다🚀

options: ImmutableList<String>
) {
Column {
options.forEach { option ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: 이거도 key 써주세요...🥹

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

onOptionSelected: (String) -> Unit,
options: ImmutableList<String>
) {
Column {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: 인자로 modifier 받아와서 Column에 넣어주는 것도 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Collaborator

@angryPodo angryPodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@Roel4990 Roel4990 merged commit 6b67f3f into develop Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT✨ 새로운 기능 구현 🧡세홍🧡 🧡세홍🧡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 신고하기 페이지 RadioButton 구현
4 participants