-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#39] 신고하기 페이지 ReportRadioButton 컴포넌트 구현 #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오~~~ 수고하셨습니다🚀
options: ImmutableList<String> | ||
) { | ||
Column { | ||
options.forEach { option -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: 이거도 key 써주세요...🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
onOptionSelected: (String) -> Unit, | ||
options: ImmutableList<String> | ||
) { | ||
Column { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: 인자로 modifier 받아와서 Column에 넣어주는 것도 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
Related issue 🛠
Work Description ✏️
Screenshot 📸
To Reviewers 📢
디쌤들과 협의해서 기본 RadioButton 사용하기로 했습니다! 실 디자인과 조금 다를 수 있어요! 감안해주세요!