More installer validation checks

SMUnlimited · Dec 17, 2023 · bfd0c0c · bfd0c0c
1 parent 9302a4f
commit bfd0c0c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ## Unreleased
 
 ### Added
+- More installer validation checks for map write access and MPQEditor presence.
 
 ### Changed
 - Balance tweaks to harvesting logic. (jzy-chitong56)

diff --git a/Electron/AMAI-release/install.js b/Electron/AMAI-release/install.js
@@ -49,6 +49,10 @@ const installOnDirectory = async () => {
     process.send(`ERROR: Cannot find ${process.cwd()}\\Scripts\\${ver}\\common.ai`)
     return
   }
+  if (!fs.existsSync(`MPQEditor.exe`)) {
+    process.send(`ERROR: Cannot find ${process.cwd()}\\MPQEditor.exe`)
+    return
+  }
   if (installCommander && !fs.existsSync(`Scripts\\Blizzard_${ver}.j`)) {
     process.send(`ERROR: Cannot find ${process.cwd()}\\Scripts\\blizzard_${ver}.j`)
     return
@@ -68,6 +72,13 @@ const installOnDirectory = async () => {
         continue;
       }
 
+      try {
+        fs.accessSync(file, fs.constants.W_OK)
+      } catch (e) {
+        process.send(`WARN: ${file} does not have write permissions so unable to install`);
+        continue;
+      }
+
       try {
         // execute same way how InstallTFTtoDir.pl