Move advanced design space handling in separate smt-design-space-ext module
#651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…going there. Also, need to extend design space class for the paper
|
@relf Okay for me! |
Paul-Saves
force-pushed
the
smt-connexion-with-designspace
branch
from
0b343eb
to
0b93b83
Compare
|
I fixed the initialization for Collab. |
relf
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Actually the module name smt_design_space is confusing, I suggest to rename it in smt_design_space_ext for external or extension I mean smt has an API for design space and a standalone internal basic design space handling which can be enhanced using smt_design_space_ext module.
Sorry for this late suggestion. Naming is a well-know hard problem in computer science
relf
reviewed
Oct 2, 2024
relf
changed the title
smt-design-space-ext module
relf
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the connection between SMT and SMT-Design-Space.
Remove code related to SMT-Design-Space moved in a new repo
--- SMTOrg/SMT-Design-Space