Temporary workaround for IfPartPattern in reviewer and other fixes #362

rkm · 2023-07-25T11:06:19Z

closes #144
closes #312

codecov-commenter · 2023-07-25T11:09:18Z

Codecov Report

Attention: 232 lines in your changes are missing coverage. Please review.

Comparison is base (6ad3891) 41.46% compared to head (6db3433) 38.56%.
Report is 59 commits behind head on main.

Files	Patch %	Lines
...entifiable/Reporting/Reports/FailureStoreReport.cs	45.69%	75 Missing and 7 partials ⚠️
ii/MainWindow.cs	0.00%	41 Missing ⚠️
ii/Program.cs	0.00%	28 Missing ⚠️
IsIdentifiable/Rules/PartPatternFilterRule.cs	63.79%	15 Missing and 6 partials ⚠️
ii/Views/RulesView.cs	0.00%	19 Missing ⚠️
ii/Views/FailureView.cs	0.00%	16 Missing ⚠️
ii/Views/TreeNodeWithCount.cs	0.00%	10 Missing ⚠️
...le/Options/IsIdentifiableReportValidatorOptions.cs	0.00%	9 Missing ⚠️
IsIdentifiable/Redacting/ReportReader.cs	40.00%	3 Missing ⚠️
IsIdentifiable/Failures/FailurePart.cs	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   41.46%   38.56%   -2.91%     
==========================================
  Files          67       69       +2     
  Lines        3803     4071     +268     
  Branches        0      554     +554     
==========================================
- Hits         1577     1570       -7     
- Misses       2226     2395     +169     
- Partials        0      106     +106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ii/Views/TreeNodeWithCount.cs

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs

IsIdentifiable/Rules/RegexRule_PartTemp.cs

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs

IsIdentifiable/Rules/PartPatternFilterRule.cs

+            matchesBefore && string.IsNullOrWhiteSpace(WordAfter) ||
+            matchesAfter && string.IsNullOrWhiteSpace(WordBefore) ||
+            (matchesBefore && matchesAfter)


IsIdentifiable/Reporting/Reports/FailureStoreReport.cs

IsIdentifiable/Rules/PartPatternFilterRule.cs

+    private Regex? _wordAfterRegex;
+
+    private int _usedCount = 0;
+    private object _usedCountLock = new();


IsIdentifiable/Reporting/Reports/FailureStoreReport.cs


-        while (r.Read())
+        int totalProcessed = 0;
+        var localTokenSource = new CancellationTokenSource();


ii/Program.cs

+        }
+
+        var report = new FailureStoreReport("", 0, fileSystem);
+        var failures = FailureStoreReport.Deserialize(fileSystem.FileInfo.New(opts.FailuresCsv), (_) => { }, new CancellationTokenSource().Token, partRules: null, runParallel: false).ToArray();


ii/Program.cs

+            return 1;
+        }
+
+        var report = new FailureStoreReport("", 0, fileSystem);


ii/Program.cs

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs

+        foreach (var partRule in partRules)
+        {
+            if (!string.IsNullOrWhiteSpace(partRule.IfColumn) && !string.Equals(partRule.IfColumn, row.ProblemField, StringComparison.InvariantCultureIgnoreCase))
+                continue;
+
+            foreach (var part in parts.Where(x => partRule.Covers(x, row.ProblemValue)))
+            {
+                toRemove.Add(part);
+                partRule.IncrementUsed();
+            }
+        }


IsIdentifiable/Reporting/Reports/FailureStoreReport.cs

ii/Program.cs

+        }
+
+        var report = new FailureStoreReport("", 0, fileSystem);
+        var failures = FailureStoreReport.Deserialize(fileSystem.FileInfo.New(opts.FailuresCsv), (_) => { }, new CancellationTokenSource().Token, partRules: null, runParallel: false, opts.StopAtFirstError).ToArray();


IsIdentifiable/Reporting/Reports/FailureStoreReport.cs

+                    if (row.ProblemValue.Substring(part.Offset, part.Word.Length) == part.Word)
+                        continue;
+                }
+                catch (ArgumentOutOfRangeException) { }


rkm · 2023-12-08T09:27:46Z

needs reworked and rebased - separate PR

rkm changed the title ~~Tempoary workaround for IfPartPattern in reviewer~~ Tempoary workaround for IfPartPattern in reviewer and other fixes Jul 25, 2023

github-advanced-security bot found potential problems Jul 25, 2023

View reviewed changes

ii/Views/TreeNodeWithCount.cs Fixed Show fixed Hide fixed

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm changed the title ~~Tempoary workaround for IfPartPattern in reviewer and other fixes~~ Temporary workaround for IfPartPattern in reviewer and other fixes Jul 25, 2023

rkm force-pushed the hotfix/ifpartpattern branch from 0e8d97f to 60dfeeb Compare August 7, 2023 10:50

github-advanced-security bot found potential problems Aug 7, 2023

View reviewed changes

IsIdentifiable/Rules/RegexRule_PartTemp.cs Fixed Show fixed Hide fixed

rkm force-pushed the hotfix/ifpartpattern branch 2 times, most recently from 1bd3912 to 492b2d8 Compare August 8, 2023 11:02

github-advanced-security bot found potential problems Aug 8, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm force-pushed the hotfix/ifpartpattern branch from 492b2d8 to 62e2622 Compare August 8, 2023 13:02

github-advanced-security bot found potential problems Aug 9, 2023

View reviewed changes

github-advanced-security bot found potential problems Aug 10, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm added 18 commits August 23, 2023 11:32

fix off-by-one error in FailureStoreReport

eeabf2f

Expand Failure detail shown in RulesView

537a1ad

adjust ii window sizing

cc7fb9e

fix count of outstanding failures and adjust node display

6c2d602

fix scroll past end of report count

df6bbc4

upload ii binary package on each CI run

52dc51d

add names to uploaded artifacts

f99bfda

exit early if file not found

71a94fa

implement ToString for FailurePart

a80c2f3

Tidy FailureView.Redraw

7815b98

add temporary ability to use PartRegexRule in reviewer

6df0217

fixup test PackageReferences

a7a9c25

don't emit a Failure if there are no parts remaining

b94b8e7

fix ii opening any CSV and silently ignoring errors

fa2986e

check IfPartPattern is properly enclosed

015a39b

support words before and after the FailurePart

a586749

fixup offset issues

024ea22

pull-up offset fixing code to cover all parts

3ec7354

rkm force-pushed the hotfix/ifpartpattern branch from adfa718 to 7cc0145 Compare August 24, 2023 10:56

github-advanced-security bot found potential problems Aug 24, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

fixup previous to handle hidden unicode

74beb43

github-advanced-security bot found potential problems Aug 24, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm added 3 commits November 14, 2023 15:29

fix PartPatternFilterRule being double-counted in title

ae555ff

add PartPatternFilterRules to title

9c5f439

add used PartPatternFilterRules as tree node

f982ac9

github-advanced-security bot found potential problems Nov 14, 2023

View reviewed changes

IsIdentifiable/Rules/PartPatternFilterRule.cs

private Regex? _wordAfterRegex;

private int _usedCount = 0;

private object _usedCountLock = new();

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_usedCountLock' can be 'readonly'.

add column and classification to tree node

b97c47d

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

add simple validator mode to ii

2bb3fdf

rkm force-pushed the hotfix/ifpartpattern branch from c34ac66 to 2bb3fdf Compare December 7, 2023 13:31

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

improve error messaging

55024e9

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

wrap exception

1b45916

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm added 2 commits December 7, 2023 13:55

ignore first exception and continue

1de68b0

include FailurePart in output

ed469b6

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm added 2 commits December 7, 2023 14:37

guard against offset starting beyond end of problem value

dc4af8b

fixup handling of HTML

100c853

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

IsIdentifiable/Reporting/Reports/FailureStoreReport.cs Fixed Show fixed Hide fixed

rkm added 2 commits December 7, 2023 15:17

rework edge case handling

d4983f4

always output

2298707

github-advanced-security bot found potential problems Dec 7, 2023

View reviewed changes

rkm added 2 commits December 7, 2023 15:25

only show used rules

96f4261

support exporting Outstanding Failures to file

6db3433

rkm closed this Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporary workaround for IfPartPattern in reviewer and other fixes #362

Temporary workaround for IfPartPattern in reviewer and other fixes #362

rkm commented Jul 25, 2023 •

edited

Loading

codecov-commenter commented Jul 25, 2023 •

edited

Loading

rkm commented Dec 8, 2023

Temporary workaround for IfPartPattern in reviewer and other fixes #362

Temporary workaround for IfPartPattern in reviewer and other fixes #362

Conversation

rkm commented Jul 25, 2023 • edited Loading

codecov-commenter commented Jul 25, 2023 • edited Loading

Codecov Report

rkm commented Dec 8, 2023

rkm commented Jul 25, 2023 •

edited

Loading

codecov-commenter commented Jul 25, 2023 •

edited

Loading