full window macOS

SLM-Audio · Aug 18, 2024 · 9585d73 · 9585d73
1 parent 28d28ae
commit 9585d73
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/cmake/serialise.cpp b/cmake/serialise.cpp
@@ -8,6 +8,7 @@
 #include <cassert>
 #include <fstream>
 #include <cstdint>
+#include <sstream>
 #include <fmt/core.h>
 
 constexpr static auto headerStart =

diff --git a/examples/gain/gain-gui/src/App.css b/examples/gain/gain-gui/src/App.css
@@ -1,8 +1,8 @@
 #root {
-    min-width: 400px;
-    max-width: 1280px;
+    min-width: 500px;
+    min-height: 500px;
     margin: 0 auto;
-    padding: 2rem;
+    padding: 0;
     text-align: center;
     align-content: center;
     justify-content: center;

diff --git a/modules/clap-wrapper b/modules/clap-wrapper
diff --git a/source/gui/mostlyharmless_WebviewEditor.cpp b/source/gui/mostlyharmless_WebviewEditor.cpp
@@ -90,7 +90,8 @@ namespace mostly_harmless::gui {
         }
 
         void destroy() {
-            helpers::macos::removeFromParentView(m_webview->getViewHandle());
+            //            helpers::macos::removeFromParentView(m_webview->getViewHandle());
+            m_webview.reset();
         }
 
         void getSize(std::uint32_t* width, std::uint32_t* height) {

diff --git a/source/gui/platform/mostlyharmless_GuiHelpersMacOS.mm b/source/gui/platform/mostlyharmless_GuiHelpersMacOS.mm
@@ -24,6 +24,7 @@ void reparentView(void* parentViewHandle, void* childViewHandle) {
         auto* child = static_cast<NSView*>(childViewHandle);
         child.frame = parent.bounds;
         [parent addSubview:child];
+        [[maybe_unused]] const auto converted = [parent.window.contentView convertRect:child.frame fromView:child];
     }
 
     void showView(void* viewHandle) {
@@ -35,4 +36,4 @@ void hideView(void* viewHandle) {
         auto* asView = static_cast<NSView*>(viewHandle);
         asView.hidden = true;
     }
-} // namespace mostly_harmless::gui::helpers
+} // namespace mostly_harmless::gui::helpers::macos
diff --git a/source/mostlyharmless_Plugin.cpp b/source/mostlyharmless_Plugin.cpp
@@ -427,12 +427,12 @@ namespace mostly_harmless {
 
     template <marvin::FloatType SampleType>
     bool Plugin<SampleType>::guiCanResize() const noexcept {
-        return false; // TODO
+        return true; // TODO
     }
 
     template <marvin::FloatType SampleType>
     bool Plugin<SampleType>::guiAdjustSize(std::uint32_t* /*width*/, std::uint32_t* /*height*/) noexcept {
-        return false; // TODO
+        return true; // TODO
     }
 
     template <marvin::FloatType SampleType>
+3 −1		src/detail/standalone/macos/AppDelegate.h
+33 −3		src/detail/standalone/macos/AppDelegate.mm
+5 −4		src/detail/standalone/windows/helpers.cpp
+2 −2		src/detail/standalone/windows/helpers.h
+14 −5		src/detail/standalone/windows/host_window.cpp
+1 −0		src/detail/standalone/windows/host_window.h