Initialise DLite search paths from entry points #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescalb
reviewed
Oct 30, 2024
francescalb
reviewed
Oct 30, 2024
Comment on lines
+38
to
+39
| All the path variables, except for `DLITE_STORAGES`, uses (`:`) colon as path separator. | ||
| However, since colon may appears in URLs, `DLITE_STORAGES` uses instead the pipe symbol (`|`) as path separator. |
There was a problem hiding this comment.
Why not have the same separator in all? Also, one could envison plugins being available on the internet somewhere (for the future)?
There was a problem hiding this comment.
Good point! I think this would be a very good thing to add as an issue. We could then deprecate the use of colon over some releases and standardise on "|"
francescalb
reviewed
Oct 30, 2024
francescalb
reviewed
Oct 30, 2024
doc/user_guide/storage_plugins.md
Outdated
|
|
||
| ``` | ||
|
|
||
| See [Extending DLite] for more information. |
There was a problem hiding this comment.
Where does this point to?
There was a problem hiding this comment.
Corrected. It now points to search_paths.html
Co-authored-by: Francesca L. Bleken <[email protected]>
Co-authored-by: Francesca L. Bleken <[email protected]>
francescalb
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow developers of packages that uses dlite to define entry_points with paths to datamodels and plugins.
Also documented DLite search paths and how to extend them.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.