Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when calling Instance.to_bytes() for drivers not supporting memsave #588

Merged
merged 3 commits into from
Aug 12, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description

Closes #587

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Aug 12, 2023 that may be closed by this pull request
@jesper-friis jesper-friis merged commit 986f13a into master Aug 12, 2023
10 checks passed
@jesper-friis jesper-friis deleted the 587-segfault-for-unsupported-memsave branch August 12, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance.to_bytes() segfaults if driver is not supported
1 participant