Make sure that the memory is released when a collection goes out of s…

…cope in Python
SINTEF · Nov 9, 2024 · 227e61a · 227e61a
1 parent 89dceb5
commit 227e61a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/bindings/python/dlite-collection-python.i b/bindings/python/dlite-collection-python.i
@@ -192,11 +192,7 @@ class Collection(Instance):
         is registered, a DLiteError is raised.
         """
         inst = _collection_get_new(self._coll, label, metaid)
-        if inst.is_meta:
-            inst.__class__ = Metadata
-        elif inst.meta.uri == COLLECTION_ENTITY:
-            inst.__class__ = Collection
-        return inst
+        return instance_cast(inst)
 
     def get_id(self, id):
         """Return instance with given id."""

diff --git a/bindings/python/dlite-collection.i b/bindings/python/dlite-collection.i
@@ -53,8 +53,7 @@ const struct _Triple *
 int dlite_collection_add(struct _DLiteCollection *coll, const char *label,
                          struct _DLiteInstance *inst);
 int dlite_collection_remove(struct _DLiteCollection *coll, const char *label);
-//const struct _DLiteInstance *
-//  dlite_collection_get(const struct _DLiteCollection *coll, const char *label);
+%newobject dlite_collection_get_new;
 struct _DLiteInstance *
 dlite_collection_get_new(const struct _DLiteCollection *coll,
                          const char *label, const char *metaid);