chore: enable hydration for declarative shadow roots #10519
+69
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarative shadow DOM
Currently
UI5Element.ts
always callsattachShadow
in theconstructor
, which in turn always creates a new shadow root (and destroys the existing declarative shadow root, if provided).This change introduces a small fix to not destroy declarative shadow roots.
Notes about using declarative shadow DOM
shadowRootOptions
to the<template>
, f.e. forButton.ts
we have:therefore it needs:
as opposed to the most commonly used:
The initial rendering will always be executed, and will ideally only attach event listeners (the pre-rendered HTML is expected to be correct)
It's strongly recommended to use:
when rendering with declarative shadow DOM.