Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-list): add correct focus style and accessibility roles for no-data item #10503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Jan 9, 2025

  • Fixed incorrect focus style for the "no data" item with and without a header-text.
  • Added role="listitem" to the "no data" item.
  • Introduced noDataAriaLabelledBy getter for managing aria-labelledby of the "no data" item.

Fixes: #10436

@NakataCode NakataCode marked this pull request as ready for review January 9, 2025 20:40
@dobrinyonkov dobrinyonkov self-requested a review January 10, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF_ACC][ui5-list]: focus style of no data list item is not correct and also missing acc role "listitem"
1 participant