feat(ui5-timeline): introduce "growing" property #10470
Open
+1,264
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinzzx
requested changes
Jan 9, 2025
hinzzx
reviewed
Jan 9, 2025
hinzzx
reviewed
Jan 9, 2025
ilhan007
reviewed
Jan 14, 2025
ilhan007
reviewed
Jan 14, 2025
hinzzx
reviewed
Jan 21, 2025
vladitasev
requested changes
Jan 23, 2025
Stoev
reviewed
Jan 23, 2025
vladitasev
reviewed
Jan 24, 2025
| } | ||
|
|
||
| get timelineEndDOM() { | ||
| return this.shadowRoot!.querySelector(".ui5-timeline-end-marker"); |
There was a problem hiding this comment.
the best practice is to use @query for this, but it's ok to leave it, just FYI
Stoev
reviewed
Jan 24, 2025
There was a problem hiding this comment.
A tentative suggestion to align the commit message text with the changes we discussed (for example: use "end" instead of "bottom" when referring to the Timeline's items' list visual end):
Similar to 'ui5-table' , we introduce a new property 'growing' to 'ui-timeline'. It provides growing property, with 3 available options:
'Button': Displays a "More" button at the end of the list, which when pressed triggers the 'load-more' event.
'Scroll': The 'load-more' event is triggered when the user scrolls to the bottom of the list.
'None': The growing functionality is off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
ui5-table, now theui5-timelineprovides growing property with 3 available options:Button: Shows a "More" button at the bottom of the listpressing of which triggers the
load-moreevent.Scroll: Theload-moreevent is triggered when the user scrolls to the bottom of the list.None: growing is off