Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbi(ui5-app-inq): update ui5 default version logic #2484

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cianmSAP
Copy link
Contributor

Updates default handling for ui5 version

  • If default version is a snapshot, the logic is unchanged, i.e. the closest published version will be returned as the default
  • If default version is not found in the version list returned from ui5-info, it will be added to the top of the list (outside of the maintained, out of maintenance seperators)

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: ceb0f51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@sap-ux/ui5-application-inquirer Patch
@sap-ux/inquirer-common Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-tooling Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/create Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/ui5-library-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP requested a review from IainSAP October 22, 2024 14:29
Copy link

sonarcloud bot commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants