fix(abap-deploy-config-inquirer ): add more robust test

packages/abap-deploy-config-inquirer/src/prompts/questions/abap-target.ts

@@ -177,12 +177,8 @@ function getScpPrompt(backendTarget?: BackendTarget): Question<AbapDeployConfigA
             const scpChoice = answers[abapDeployConfigInternalPromptNames.scp];
             const targetChoice = answers[abapDeployConfigInternalPromptNames.targetSystem];
             // scpChoice by default is true so only update state if target system is a URL
-            if (scpChoice == true && targetChoice === TargetSystemType.Url) {
-                PromptState.abapDeployConfig.scp = true;
-            } else if (targetChoice === TargetSystemType.Url) {
-                // Needs to be reset when user is toggling between scp and non-scp
-                PromptState.abapDeployConfig.scp = false;
-            }
+            PromptState.abapDeployConfig.scp =
+                scpChoice === true && targetChoice === TargetSystemType.Url ? true : false;
             return false;
         },
         name: abapDeployConfigInternalPromptNames.scpSetter

packages/abap-deploy-config-inquirer/test/prompts/questions/abap-target.test.ts

@@ -338,6 +338,7 @@ describe('getAbapTargetPrompts', () => {
                     scp: true
                 })
             ).toBe(false);
+            expect(PromptState.abapDeployConfig.scp).toBe(true);
             // Lets toggle the question
             expect(
                 (scpSetterPrompt.when as Function)({
@@ -347,6 +348,14 @@ describe('getAbapTargetPrompts', () => {
                 })
             ).toBe(false);
             expect(PromptState.abapDeployConfig.scp).toBe(false);
+            // When SCP is not answered
+            expect(
+                (scpSetterPrompt.when as Function)({
+                    targetSystem: TargetSystemType.Url,
+                    url: 'https://mock.target1.url.com'
+                })
+            ).toBe(false);
+            expect(PromptState.abapDeployConfig.scp).toBe(false);
         } else {
             throw new Error('Scp setter prompt not found');
         }