Adds node params to compound container typings #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmazacn
requested review from
ndricimrr,
VincentUllal,
smahati and
amilewskaa
as code owners
ndricimrr
reviewed
Sep 23, 2024
| @@ -24,6 +24,12 @@ export default class LuigiCompoundContainer extends HTMLElement { | |||
| */ | |||
| deferInit: boolean; | |||
|
|
|||
| /** | |||
| * The parameters to be passed to the compound micro frontend. | |||
| * @since NEXT_RELEASE_CONTAINER | |||
There was a problem hiding this comment.
I am not sure about the NEXT_RELEASE_CONTAINER since nodeParams was added in [email protected]
@since 1.0.0 would be correct here I think
| @@ -24,6 +24,12 @@ export default class LuigiCompoundContainer extends HTMLElement { | |||
| */ | |||
| deferInit: boolean; | |||
|
|
|||
| /** | |||
| * The parameters to be passed to the compound micro frontend. | |||
There was a problem hiding this comment.
Suggested change
| * The parameters to be passed to the compound micro frontend. | |
| * The parameters to be passed to the compound micro frontend. Will not be passed to the compound children. |
Seems like this part is missing here. since we skip it for compound children.
Also I saw that this sentence "Will not be passed to the compound children." is present on LuigiContainer Typings : nodeParams . It should be removed from there and be kept here, since LuigiContainer doesn't deal with compound and that part there is wrong. You can do it in this PR maybe since its related
walmazacn
deleted the
3924-node-params-in-compound-container-typings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #3924