Skip to content

Commit

Permalink
Fixes code review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
walmazacn committed Sep 23, 2024
1 parent 0fef334 commit 94ef4de
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions container/typings/LuigiCompoundContainer.svelte.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export default class LuigiCompoundContainer extends HTMLElement {
deferInit: boolean;

/**
* The parameters to be passed to the compound micro frontend.
* @since NEXT_RELEASE_CONTAINER
* The parameters to be passed to the compound micro frontend. Will not be passed to the compound children.
* @since 1.0.0
*/
nodeParams: Object;

Expand Down
2 changes: 1 addition & 1 deletion container/typings/LuigiContainer.svelte.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export default class LuigiContainer extends HTMLElement {
skipInitCheck: boolean;

/**
* The parameters to be passed to the web-component-based micro frontend. Will not be passed to the compound children.
* The parameters to be passed to the web-component-based micro frontend.
* @since 1.0.0
*/
nodeParams: Object;
Expand Down
4 changes: 2 additions & 2 deletions docs/luigi-compound-container-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ Type: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Glob

### nodeParams

The parameters to be passed to the compound micro frontend.
The parameters to be passed to the compound micro frontend. Will not be passed to the compound children.

Type: [Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)

**Meta**

* **since**: NEXT_RELEASE_CONTAINER
* **since**: 1.0.0

### noShadow

Expand Down
2 changes: 1 addition & 1 deletion docs/luigi-container-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Type: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Glob

### nodeParams

The parameters to be passed to the web-component-based micro frontend. Will not be passed to the compound children.
The parameters to be passed to the web-component-based micro frontend.

Type: [Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)

Expand Down

0 comments on commit 94ef4de

Please sign in to comment.