Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog #12502

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog #12502

wants to merge 9 commits into from

Commits on Oct 2, 2024

  1. refactor(platform): Refactor to leverage signals and combine sorting,… 

    … filtering, and grouping dialogs into a single settings dialog.
    @dpavlenishvili
    dpavlenishvili committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a5a6abc View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. refactor(platform, docs): generate tests, add combined settings example

    @dpavlenishvili
    dpavlenishvili committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    883a1b2 View commit details
    Browse the repository at this point in the history

  2. fix(platform): add cursor pointer style to filter list items

    @dpavlenishvili
    dpavlenishvili committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    830debb View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. fix(platform): remove cursor pointer style temp fix to filter list it… 

    …ems, remove unused cdt declaration, removed signal effect and used just input set to listen filteringData change to triger relevant methods accordingly.
    @dpavlenishvili
    dpavlenishvili committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    51d98d3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 12441-table-settings-dialog-revisit 

    # Conflicts:
#	libs/platform/table/components/table-view-settings-dialog/grouping/grouping.component.html
#	libs/platform/table/components/table-view-settings-dialog/grouping/grouping.component.ts
#	libs/platform/table/components/table-view-settings-dialog/sorting/sorting.component.html
#	libs/platform/table/components/table-view-settings-dialog/sorting/sorting.component.ts
    @dpavlenishvili
    dpavlenishvili committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2b18f76 View commit details
    Browse the repository at this point in the history

  3. fix(platform): merge conflict missing parts

    @dpavlenishvili
    dpavlenishvili committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f08631d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into 12441-table-settings-dialog-revisit

    @dpavlenishvili
    dpavlenishvili authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5cf2261 View commit details
    Browse the repository at this point in the history

  2. fix(docs): sync settings dialog and table data in platform table exam… 

    …ples
    @dpavlenishvili
    dpavlenishvili committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    40b4983 View commit details
    Browse the repository at this point in the history

  3. fix(platform): remove settings dialog scss file and set height style … 

    …as inline
    @dpavlenishvili
    dpavlenishvili committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    aae72fa View commit details
    Browse the repository at this point in the history