Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-common: weakly activate rand_core/getrandom #1381

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

tarcieri
Copy link
Member

When both getrandom and rand_core are enabled, activates the rand_core/getrandom feature, which makes OsRng available as crypto_common::rand_core::OsRng.

When both `getrandom` and `rand_core` are enabled, activates the
`rand_core/getrandom` feature, which makes `OsRng` available as
`crypto_common::rand_core::OsRng`.
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add getrandom re-export?

#[cfg(feature = "getrandom")]
pub use getrandom;

It may be needed for properly handling getrandom::Error. I forgot to do it in the previous PR.

@tarcieri tarcieri merged commit b6b591e into master Nov 12, 2023
84 checks passed
@tarcieri tarcieri deleted the crypto-common/weak-rand_core/getrandom-activation branch November 12, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants