Committing AEAD marker traits and generic constructions #1365
Conversation
TODO: bikeshedding of names and constructions that need changes to the underlying AEAD traits
While this exact construction hasn't appeared in the literature, it is similar to CTX, with the original tag being exposed to allow it to be implemented with the current AEAD traits, and a follow-up substitution of HMAC instead of a raw hash function to ensure that exposing the original tag does not open the committment up to length-extension type vulnerabilities.
In-place en/decryption doesn't quite make sense when the padding adds a ciphertext overhead
Turns out Aead and AeadMut do not clash with each other
|
Seems like the test failures are caused by the cipher crate emitting a warning in the minimal version build, as opposed to being related to any of the changes I made. |
|
I think it will be better to move the wrapper into a different crate in the AEADs repository and link it in the new wrappers trait docs. |
|
Yeah, I had a similar first thought: this might make sense in a separate crate. If it were located in the https://github.com/RustCrypto/AEADs/ repo it would be much easier to test the generic implementation against a concrete AEAD algorithm implementation located there. |
|
I'll move the wrappers into a separate PR to the AEADs repo, but I'll also take the time to add some tests using concrete AEADs. However, I'd like to confirm whether you think it'd be better to keep the marker traits in the |
|
I opened a PR against the AEADs repo at RustCrypto/AEADs#564, so I'll close this one. I will send in a PR to cross-reference the new crate in the |
|
Sounds good. Since committing AEADs can be completely implemented in that crate, it seems like there isn't much value in having upstream marker traits? We're going to start making breaking changes to |
|
Forgot to mention this, but I decided to move the marker traits into the new crate as well. Also, thanks for the heads up about upcoming breaking changes to the |
See the documentation comments for an explanation of committing AE and the generic constructions included.