elliptic-curve: minimum supported tap for bits is v1.0.1
#1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when resolving with `-Z minimal-versions` `tap` is a transitive dependency of `bitvec` by way of `wyz` v0.5, which misspecifies the required `tap` version. This is addressed in newer v0.6 releases of `wyz`, which `bitvec` does not yet use. So, as a workaround, this adds an explicit `dep:tap` dependency on v1.0.1 for the `bits` feature. This was the last remaining `minimal-versions` incompatibility in this crate, allowing all features to now be tested in the `minimal-versions` check in CI.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when resolving with
-Z minimal-versionstapis a transitive dependency ofbitvecby way ofwyzv0.5, which misspecifies the requiredtapversion. This is addressed in newer v0.6 releases ofwyz, whichbitvecdoes not yet use.So, as a workaround, this adds an explicit
dep:tapdependency on v1.0.1 for thebitsfeature.This was the last remaining
minimal-versionsincompatibility in this crate, allowing all features to now be tested in theminimal-versionscheck in CI.