keccak: 2021 edition upgrade; MSRV 1.60 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Jan 12, 2024
.github/workflows/keccak.yml
Outdated
| msrv: 1.41.0 | ||
| msrv: 1.59.0 |
There was a problem hiding this comment.
I would probably recommend changing MSRV to 1.60 just to leave the door open for ascon to use weak/namespaced features in the future, though there isn't a specific requirement for that in the keccak crate itself
|
Since we're making breaking changes elsewhere in the project, I thought it was about time to bump |
newpavlov
approved these changes
Jan 12, 2024
`keccak` was previously excluded from the toplevel workspace due to its MSRV of 1.41 and incompatibilities with packages used by `ascon`. This bumps the edition, changes the version to `0.2.0-pre` to denote it contains breaking changes (though this is not intended to be a `0.2.0-pre` release), and bumps MSRV. With the MSRV bumped, `keccak` can and has been re-added to the toplevel workspace.
tarcieri
force-pushed
the
keccak/2021-edition-and-add-back-to-workspace
branch
from
75debec
to
70309c7
Compare
tarcieri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keccakwas previously excluded from the toplevel workspace due to its MSRV of 1.41 and incompatibilities with packages used byascon.This bumps the edition, changes the version to
0.2.0-preto denote it contains breaking changes (though this is not intended to be a0.2.0-prerelease), and bumps MSRV 1.59 so that the crate has a single consistent MSRV regardless of whether or not theasmfeature is enabled.With the MSRV bumped,
keccakcan and has been re-added to the toplevel workspace.