keccak: don't test simd feature in minimal-versions workflow
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Motivation is the build failure here: https://github.com/RustCrypto/sponges/actions/runs/6900548666/job/18773881810 |
It requires `nightly`, whereas the tests are run under `stable`. The `simd` feature itself is already tested in the `test-simd` job.
tarcieri
force-pushed
the
keccak/dont-test-simd-in-minimal-versions
branch
from
2197610
to
8b0bae5
Compare
newpavlov
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires
nightly, whereas the tests are run understable.The
simdfeature itself is already tested in thetest-simdjob.