Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare pre.0 prereleases #488

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

baloo
Copy link
Member

@baloo baloo commented Feb 6, 2024

Prepare releases of:

  • balloon-hash 0.5.0-pre.0
  • bcrypt-pbkdf 0.11.0-pre.0
  • password-auth 1.1.0-pre.0
  • pbkdf2 0.13.0-pre.0
  • scrypt 0.12.0-pre.0
  • sha-crypt 0.6.0-pre.0
  • argon2 0.6.0-pre.0

This brings:

  • digest =0.11.0-pre.8
  • sha1 =0.11.0-pre.3
  • sha2 =0.11.0-pre.3
  • hmac =0.13.0-pre.3
  • blake2 =0.11.0-pre3

@baloo baloo marked this pull request as draft February 6, 2024 07:42
@baloo baloo marked this pull request as ready for review February 6, 2024 07:51
@@ -183,7 +183,7 @@ where
}

Digest::update(&mut digest, idx_block);
let other = digest.finalize_reset().into_uint_le() % s_cost_bigint;
let other = digest.finalize_reset().into_uint_le() % s_cost_bigint.clone();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I'm not sure. I don't think I have a choice though.

@tarcieri
Copy link
Member

tarcieri commented Feb 6, 2024

This needs updated too (it doctests the toplevel README.md): https://github.com/RustCrypto/password-hashes/blob/master/.readme/Cargo.toml

@baloo
Copy link
Member Author

baloo commented Feb 6, 2024

This needs updated too (it doctests the toplevel README.md): https://github.com/RustCrypto/password-hashes/blob/master/.readme/Cargo.toml

I think it would just require for a pre-release version of blake2 to be published
https://crates.io/crates/blake2/versions

That would fix both failing tests here (and allow me to remove the [patch.crates-io] i added to test this)

@tarcieri
Copy link
Member

tarcieri commented Feb 6, 2024

Aah sure, we can do that

@baloo
Copy link
Member Author

baloo commented Feb 7, 2024

This pulls RustCrypto/hashes#560

@baloo
Copy link
Member Author

baloo commented Feb 7, 2024

the release blake2 fixes the issues here.
I went and set the versions as -pre.0 which suppose they get published immediately to crates.io. I could just put them back to -pre instead.

@tarcieri
Copy link
Member

tarcieri commented Feb 7, 2024

It’s fine to bump the versions for immediate publishing

@tarcieri tarcieri merged commit fe67dc8 into RustCrypto:master Feb 8, 2024
54 checks passed
@tarcieri
Copy link
Member

tarcieri commented Feb 8, 2024

I cut prereleases of all of the crates

@baloo baloo deleted the baloo/prereleases branch February 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants