Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable stack probes #363

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Disable stack probes #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions arch/arm64/rust/target.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@
"relocation-model": "static",
"relro-level": "full",
"stack-probes": {
"kind": "inline-or-call",
"min-llvm-version-for-inline": [
11,
0,
1
]
"kind": "none"
},
"target-c-int-width": "32",
"target-endian": "little",
Expand Down
7 changes: 1 addition & 6 deletions arch/riscv/rust/rv32ima.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@
"relocation-model": "static",
"relro-level": "full",
"stack-probes": {
"kind": "inline-or-call",
"min-llvm-version-for-inline": [
11,
0,
1
]
"kind": "none"
},
"target-c-int-width": "32",
"target-endian": "little",
Expand Down
7 changes: 1 addition & 6 deletions arch/riscv/rust/rv32imac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@
"relocation-model": "static",
"relro-level": "full",
"stack-probes": {
"kind": "inline-or-call",
"min-llvm-version-for-inline": [
11,
0,
1
]
"kind": "none"
},
"target-c-int-width": "32",
"target-endian": "little",
Expand Down
7 changes: 1 addition & 6 deletions arch/riscv/rust/rv64ima.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@
"relocation-model": "static",
"relro-level": "full",
"stack-probes": {
"kind": "inline-or-call",
"min-llvm-version-for-inline": [
11,
0,
1
]
"kind": "none"
},
"target-c-int-width": "32",
"target-endian": "little",
Expand Down
7 changes: 1 addition & 6 deletions arch/riscv/rust/rv64imac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@
"relocation-model": "static",
"relro-level": "full",
"stack-probes": {
"kind": "inline-or-call",
"min-llvm-version-for-inline": [
11,
0,
1
]
"kind": "none"
},
"target-c-int-width": "32",
"target-endian": "little",
Expand Down
7 changes: 1 addition & 6 deletions arch/x86/rust/target.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@
"relocation-model": "static",
"relro-level": "full",
"stack-probes": {
"kind": "inline-or-call",
"min-llvm-version-for-inline": [
11,
0,
1
]
"kind": "none"
},
"target-c-int-width": "32",
"target-endian": "little",
Expand Down
4 changes: 0 additions & 4 deletions rust/compiler_builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ macro_rules! define_panicking_intrinsics(
}
);

define_panicking_intrinsics!("non-inline stack probes should not be used", {
__rust_probestack,
});
Comment on lines -45 to -47
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove this? i.e. can we keep it as a safeguard?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to remove this so we know there're no calls generated by accident. Note that we will never need __rust_probestack in the future -- once LLVM bug is fixed we'll switch to inline stack probes.

Copy link
Member

@bjorn3 bjorn3 Jun 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this ensures that non-inline stack probes are never generated.

Edit: race-condition :)


define_panicking_intrinsics!("`f32` should not be used", {
__addsf3,
__addsf3vfp,
Expand Down