Add additional Logging level functions to the logging module #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobrand
reviewed
Oct 24, 2024
| } | ||
| } | ||
|
|
||
| unsafe fn sdl_log_critical(category: libc::c_int, fmt: *const libc::c_char){ |
There was a problem hiding this comment.
There is no point in defining those, juste use sys::SDL_ functions directly. Users from sdl2 have access to sdl2::sys so there is no re-export issue.
|
Thanks, I will have a look once you fix my comment. Also don't forget to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add Log prioriyt dependent logging functions:
where * is: create, warning, error etc.
In addition to the message those new functions will take the Category as paraemter,
the Category needs to be converted to c_int, if that fails, Application value is taken and assumed it will be convertible to c_int.