Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo mode to dashboard (part 2) #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add demo mode to dashboard (part 2) #108

wants to merge 1 commit into from

Conversation

dashby3000
Copy link

Adding a demo option to allow being able to show the dashboard publicly (from demos) without worry of giving the ability to start HEAP dumps or Profiling.

Adding a demo option to allow being able to show the dashboard publicly (from demos) without worry of giving the ability to start HEAP dumps or Profiling.
@codecov-io
Copy link

codecov-io commented Aug 26, 2017

Codecov Report

Merging #108 into master will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage    60.6%   59.74%   -0.87%     
==========================================
  Files           2        2              
  Lines         231      231              
==========================================
- Hits          140      138       -2     
- Misses         91       93       +2
Impacted Files Coverage Δ
lib/appmetrics-dash.js 59.56% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fab4ed...dbd5f42. Read the comment docs.

@sjanuary sjanuary changed the title Update index.html Add demo mode to dashboard (part 2) Sep 26, 2017
@sjanuary sjanuary self-requested a review September 26, 2017 10:33
Copy link
Contributor

@sjanuary sjanuary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes as described in #107. Should be combined into 1 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants