-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Call _end via read method #43
Conversation
@rubensworks - in your implementation of You will see that I have changed this behavior in ed8d491 - this is because as discussed here removing a 'data' listener should not pause the stream, so in the case of your tests with infinite iterators the test suite was entering an infinite loop. An alternative is to call |
The reasoning here was that the iterator could still be used after calling |
In general, I like to leave options open. So the idea is that, after But |
resolves #25 #35