fixing the last bits

RocketSurgeonsGuild · Jan 1, 2025 · d02993f · d02993f
1 parent 90ba87d
commit d02993f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -111,15 +111,15 @@
         <PackageVersion Include="Polly" Version="8.5.0" />
         <PackageVersion Include="StronglyTypedId" Version="1.0.0-beta08" />
         <PackageVersion Include="Rocket.Surgery.Build.Information" Version="3.3.11" />
-        <PackageVersion Include="Rocket.Surgery.Conventions" Version="14.0.1-beta.43" />
-        <PackageVersion Include="Rocket.Surgery.Conventions.Abstractions" Version="14.0.1-beta.43" />
-        <PackageVersion Include="Rocket.Surgery.Conventions.DryIoc" Version="14.0.1-beta.43" />
-        <PackageVersion Include="Rocket.Surgery.Conventions.Serilog" Version="14.0.1-beta.43" />
-        <PackageVersion Include="Rocket.Surgery.CommandLine" Version="14.0.1-beta.43" />
+        <PackageVersion Include="Rocket.Surgery.Conventions" Version="14.0.1-beta.44" />
+        <PackageVersion Include="Rocket.Surgery.Conventions.Abstractions" Version="14.0.1-beta.44" />
+        <PackageVersion Include="Rocket.Surgery.Conventions.DryIoc" Version="14.0.1-beta.44" />
+        <PackageVersion Include="Rocket.Surgery.Conventions.Serilog" Version="14.0.1-beta.44" />
+        <PackageVersion Include="Rocket.Surgery.CommandLine" Version="14.0.1-beta.44" />
         <PackageVersion Include="Rocket.Surgery.DependencyInjection.Extensions" Version="13.0.0-beta.34" />
         <PackageVersion Include="Rocket.Surgery.Extensions" Version="13.0.0-beta.34" />
-        <PackageVersion Include="Rocket.Surgery.Hosting" Version="14.0.1-beta.43" />
-        <PackageVersion Include="Rocket.Surgery.WebAssembly.Hosting" Version="14.0.1-beta.43" />
+        <PackageVersion Include="Rocket.Surgery.Hosting" Version="14.0.1-beta.44" />
+        <PackageVersion Include="Rocket.Surgery.WebAssembly.Hosting" Version="14.0.1-beta.44" />
         <PackageVersion Include="Scrutor" Version="5.1.0" />
         <PackageVersion Include="Serilog" Version="4.2.0" />
         <PackageVersion Include="Serilog.AspNetCore" Version="9.0.0" />

diff --git a/src/AspNetCore/Conventions/AspNetCoreConvention.cs b/src/AspNetCore/Conventions/AspNetCoreConvention.cs
@@ -23,6 +23,7 @@ namespace Rocket.Surgery.LaunchPad.AspNetCore.Conventions;
 [PublicAPI]
 [ExportConvention]
 [ConventionCategory(ConventionCategory.Application)]
+[RequiresUnreferencedCode("Registering the MVC services requires access to the application's compiled assemblies.")]
 public class AspNetCoreConvention(AspNetCoreOptions? options = null) : IServiceConvention
 {
     internal static void PopulateDefaultParts(
@@ -91,7 +92,6 @@ private static IEnumerable<Assembly> GetAssemblyClosure(Assembly assembly)
     /// <param name="configuration"></param>
     /// <param name="services"></param>
     /// TODO Edit XML Comment Template for Register
-    [RequiresUnreferencedCode()]
     public void Register(IConventionContext context, IConfiguration configuration, IServiceCollection services)
     {
         ArgumentNullException.ThrowIfNull(context);