Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to minimize the total number of warnings #1239

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v12.8.2 milestone Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1239 (d2ba7d5) into master (a9c2912) will decrease coverage by 0.09%.
The diff coverage is 74.09%.

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   74.40%   74.32%   -0.09%     
==========================================
  Files          86       86              
  Lines        3974     4043      +69     
  Branches      356      358       +2     
==========================================
+ Hits         2957     3005      +48     
- Misses       1017     1038      +21     
Files Coverage Δ
...nventions.Abstractions/ConventionContextBuilder.cs 59.86% <100.00%> (ø)
...ntions.Abstractions/ConventionContextExtensions.cs 72.72% <100.00%> (+0.41%) ⬆️
...bstractions/ServiceProviderDictionaryExtensions.cs 53.12% <ø> (ø)
...c/Conventions.Analyzers/ConventionAttributeData.cs 100.00% <100.00%> (ø)
...nventions.Analyzers/ConventionConfigurationData.cs 98.94% <100.00%> (+0.04%) ⬆️
...ns.Attributes/ConventionsConfigurationAttribute.cs 0.00% <ø> (ø)
...ns.CommandLine/AppSettingsConfigurationProvider.cs 86.66% <100.00%> (+0.30%) ⬆️
...ns.CommandLine/CommandLineHostBuilderExtensions.cs 40.81% <ø> (ø)
src/Conventions.CommandLine/ConsoleConvention.cs 97.10% <100.00%> (ø)
src/Conventions.CommandLine/ConsoleInterceptor.cs 100.00% <100.00%> (ø)
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@david-driscoll david-driscoll merged commit 5104f36 into master Oct 29, 2023
9 of 11 checks passed
@david-driscoll david-driscoll deleted the feature/warnings branch October 29, 2023 21:52
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Oct 29, 2023
@rsg-bot rsg-bot modified the milestones: v12.8.2, v12.9.0 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants