Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add GpsLocation #241

Merged
merged 3 commits into from
Jan 6, 2024
Merged

feature: add GpsLocation #241

merged 3 commits into from
Jan 6, 2024

Conversation

RLittlesII
Copy link
Contributor

@RLittlesII RLittlesII commented Jan 4, 2024

  • feature: add GpsLocation

@RLittlesII RLittlesII force-pushed the feature/gps-location branch from 7fb357b to 609bde8 Compare January 4, 2024 03:08
@github-actions github-actions bot added this to the v0.11.0 milestone Jan 4, 2024
@RLittlesII RLittlesII added the 🚀 feature This adds some form of new functionality label Jan 4, 2024
switch Location Events to use GpsLocation for underlying platform locations
add GeoCoordinate
remove beacon events and properties
+semver: minor
@RLittlesII RLittlesII force-pushed the feature/gps-location branch from a1e50f6 to 2c386d2 Compare January 6, 2024 21:59
@RLittlesII RLittlesII enabled auto-merge (squash) January 6, 2024 21:59
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (0a4a54e) 48.25% compared to head (4f4d406) 46.08%.

Files Patch % Lines
src/Core/Locations/GpsLocation.cs 0.00% 22 Missing ⚠️
src/Core/Locations/GeoCoordinate.cs 23.52% 13 Missing ⚠️
src/Core/Geofence/GeoRegion.cs 0.00% 8 Missing ⚠️
src/Core/Locations/Events/VisitedEvent.cs 0.00% 2 Missing ⚠️
src/Core/Locations/Events/ErrorEvent.cs 0.00% 1 Missing ⚠️
src/Core/Locations/Events/LocationUpdatedEvent.cs 0.00% 1 Missing ⚠️
src/Core/Locations/Events/LocationsUpdatedEvent.cs 0.00% 1 Missing ⚠️
src/Core/Locations/Events/RegionChangedEvent.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   48.25%   46.08%   -2.18%     
==========================================
  Files          56       60       +4     
  Lines         833      881      +48     
  Branches       38       42       +4     
==========================================
+ Hits          402      406       +4     
- Misses        431      475      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RLittlesII RLittlesII merged commit 6fc8543 into master Jan 6, 2024
4 of 6 checks passed
@RLittlesII RLittlesII deleted the feature/gps-location branch January 6, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature This adds some form of new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant