-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Individual Fin #686
Draft
MateusStano
wants to merge
5
commits into
develop
Choose a base branch
from
enh/individual-fins
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ENH: Individual Fin #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kevin-alcaniz <[email protected]>
Co-authored-by: kevin-alcaniz <[email protected]>
MateusStano
added
Enhancement
New feature or request, including adjustments in current codes
Aerodynamics
Any problem to be worked on top of RocketPy's Aerodynamic
labels
Sep 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enh/generic-surfaces #686 +/- ##
========================================================
- Coverage 74.91% 72.26% -2.65%
========================================================
Files 87 94 +7
Lines 10308 10899 +591
========================================================
+ Hits 7722 7876 +154
- Misses 2586 3023 +437 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Aerodynamics
Any problem to be worked on top of RocketPy's Aerodynamic
Enhancement
New feature or request, including adjustments in current codes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Description
Individual fins have been added to RocketPy:
Fin
class,TrapezoidalFin
class andEllipsoidalFin
class have been addedBreaking change
Remaining Tasks
will not work for IndividualFins
It would be truly great to get some help on these minor tasks
Contributors
Special thanks to @kevin-alcaniz and Faraday Rocketry UPV for their contributions!!