-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong user role showing in channel #33287
base: develop
Are you sure you want to change the base?
Conversation
…n ui does not get update
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 8b57df2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33287 +/- ##
===========================================
- Coverage 59.70% 59.70% -0.01%
===========================================
Files 2551 2550 -1
Lines 62792 62787 -5
Branches 14102 14102
===========================================
- Hits 37492 37487 -5
Misses 22893 22893
Partials 2407 2407
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
this PR will fix the #33162
Issue(s)
Closes #33162
Steps to test or reproduce
Further comments
I need clarification on the following:
I’ve resolved the issue we discussed, and the solution is now working as expected. However, I wanted to get your input on optimizing the current implementation. Specifically, I’ve noticed that multiple API calls are being made, and I’m wondering if there are any strategies or best practices you would recommend to reduce the number of API calls without impacting functionality.
The RoomRoles state is marked as deprecated. Can I safely remove it from the codebase?