Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong user role showing in channel #33287

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Kishn0109
Copy link
Contributor

Proposed changes (including videos or screenshots)

this PR will fix the #33162

Issue(s)

Closes #33162

Steps to test or reproduce

  1. Add a new admin user to a channel or team.
  2. Remove the user.
  3. Add the user back, When adding it back, the user is still shown as an owner.

Further comments

I need clarification on the following:

image

  • I’ve resolved the issue we discussed, and the solution is now working as expected. However, I wanted to get your input on optimizing the current implementation. Specifically, I’ve noticed that multiple API calls are being made, and I’m wondering if there are any strategies or best practices you would recommend to reduce the number of API calls without impacting functionality.

  • The RoomRoles state is marked as deprecated. Can I safely remove it from the codebase?

@Kishn0109 Kishn0109 requested a review from a team as a code owner September 15, 2024 07:11
Copy link
Contributor

dionisio-bot bot commented Sep 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 15, 2024

🦋 Changeset detected

Latest commit: 8b57df2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Kishn0109 Kishn0109 changed the title Fix/channel user roles fix: wrong user role showing in channel Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (399fb73) to head (5c0fd55).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33287      +/-   ##
===========================================
- Coverage    59.70%   59.70%   -0.01%     
===========================================
  Files         2551     2550       -1     
  Lines        62792    62787       -5     
  Branches     14102    14102              
===========================================
- Hits         37492    37487       -5     
  Misses       22893    22893              
  Partials      2407     2407              
Flag Coverage Δ
unit 76.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching issue -- Problems when owner is removed from a team or channel and then added again
2 participants