Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New marketplace state for out of support window workspaces #33238

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Sep 9, 2024

Proposed changes (including videos or screenshots)

  • Adds a new empty state to the marketplace when a workspace is out of the support window

Screenshot 2024-09-09 at 14 14 53

Also does some changes to the marketplace orchestrator so it properly receive errors from failed api calls

Issue(s)

PASLR-18
https://rocketchat.atlassian.net/browse/PASLR-6

Copy link
Contributor

dionisio-bot bot commented Sep 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 378e18f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/i18n Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (065a742) to head (378e18f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33238   +/-   ##
========================================
  Coverage    58.42%   58.42%           
========================================
  Files         2745     2745           
  Lines        66279    66276    -3     
  Branches     14999    14998    -1     
========================================
  Hits         38724    38724           
+ Misses       24733    24730    -3     
  Partials      2822     2822           
Flag Coverage Δ
unit 74.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler changed the title feat: New outdated marketplace empty state feat: New marketplace empty states Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33238/
on branch gh-pages at 2024-10-15 17:05 UTC

@MartinSchoeler MartinSchoeler changed the base branch from develop to release-7.0.0 September 16, 2024 12:27
@MartinSchoeler MartinSchoeler added this to the 7.0 milestone Sep 16, 2024
@MartinSchoeler MartinSchoeler modified the milestones: 7.0, 6.13 Sep 18, 2024
@MartinSchoeler MartinSchoeler changed the base branch from release-7.0.0 to develop September 18, 2024 17:21
@MartinSchoeler MartinSchoeler changed the title feat: New marketplace empty states feat: New marketplace state for out of support window workspace Sep 18, 2024
@MartinSchoeler MartinSchoeler changed the title feat: New marketplace state for out of support window workspace feat: New marketplace state for out of support window workspaces Sep 18, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 19, 2024 21:34
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner September 19, 2024 21:34
@lucas-a-pelegrino lucas-a-pelegrino modified the milestones: 6.13, 7.0 Sep 23, 2024
@lucas-a-pelegrino lucas-a-pelegrino changed the base branch from develop to release-7.0.0 September 30, 2024 18:12
@dionisio-bot dionisio-bot bot added stat: conflict stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested stat: conflict labels Oct 3, 2024
@MartinSchoeler MartinSchoeler removed the request for review from dougfabris October 14, 2024 17:29
@MartinSchoeler MartinSchoeler marked this pull request as draft October 14, 2024 19:32
@MartinSchoeler
Copy link
Contributor Author

Moving this to draft since we decided to merge this into develop

@MartinSchoeler MartinSchoeler changed the base branch from release-7.0.0 to develop October 14, 2024 19:35
@MartinSchoeler MartinSchoeler modified the milestones: 7.0, 6.14 Oct 14, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 14, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 14, 2024 20:29
.changeset/two-geckos-train.md Outdated Show resolved Hide resolved
apps/meteor/client/apps/orchestrator.ts Outdated Show resolved Hide resolved
@aleksandernsilva aleksandernsilva added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 15, 2024
@kodiakhq kodiakhq bot merged commit 31eb47f into develop Oct 15, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the unsuported-marketplace branch October 15, 2024 20:12
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants