Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get contact by id endpoint #33041

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat: get contact by id endpoint #33041

merged 6 commits into from
Sep 16, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Aug 13, 2024

Proposed changes (including videos or screenshots)

Implemented a new endpoint to retrieve contact info by id.

[GET] api/v1/omnichannel/contacts.get?contactId=123
response example:

{
	"contact": {
		"_id": "123",
		"name": "john doe",
		"emails": [
			"[email protected]"
		],
		"phones": [
			"1-658-751-2622"
		],
		"contactManager": "321",
		"customFields": {},
		"unknown": false,
	},
	"success": true
}

Issue(s)

Steps to test or reproduce

Further comments

SCI-36

Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: 12814c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tapiarafael tapiarafael changed the base branch from develop to feat/unknown-contacts August 13, 2024 19:43
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (2e10a45) to head (12814c5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33041   +/-   ##
========================================
  Coverage    59.70%   59.70%           
========================================
  Files         2551     2551           
  Lines        62792    62792           
  Branches     14102    14102           
========================================
  Hits         37492    37492           
  Misses       22893    22893           
  Partials      2407     2407           
Flag Coverage Δ
unit 76.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from feat/unknown-contacts to develop September 9, 2024 15:24
@tapiarafael tapiarafael marked this pull request as ready for review September 9, 2024 16:58
@tapiarafael tapiarafael requested review from a team as code owners September 9, 2024 16:58
Copy link
Contributor

github-actions bot commented Sep 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-16 13:43 UTC

@MarcosSpessatto MarcosSpessatto added this to the 7.0 milestone Sep 11, 2024
@tapiarafael tapiarafael added the stat: QA assured Means it has been tested and approved by a company insider label Sep 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 16, 2024
@kodiakhq kodiakhq bot merged commit fad7f97 into develop Sep 16, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the feat/get-contact-by-id branch September 16, 2024 13:42
Akshanshkaushal added a commit to Akshanshkaushal/Rocket.Chat that referenced this pull request Sep 16, 2024
mute feature test cases added

mute feature lint errors fixed

unit tests mute feature

lint error resolved mute feature

lint error resolved mute feature

lint error resolved mute feature

lint error resolved mute feature

ci: Include hidden files when uploading artifacts (RocketChat#33286)

feat: get contact by id endpoint (RocketChat#33041)
KevLehman pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants