This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW FEATURE] Theme Engine for Changing and Adding Custom Themes. #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new attribute colorHeadings.
Added recycler view and removed toggle buttons.
[FIX] Fixed Dependency Injection to work with BaseActivity.
[Improvement] Completed UI for ThemesFragment.kt
[FIX] Fixed status and navigation bar theming issue.
Implemented fade in and fade out animation to provide smoother theme switches.
[Improvement] Provided Smooth Theme Switching.
[FIX] Fixed issue with message responses.
[FIX] Changed code for theme switching.
[Improvement] Provided additional features.
Added new method for tinting drawables on top of TextViews.
Improved Theming Across App.
[FIX] Fixed Issue with Base Themes.
[FIX] Fixed Scrolling Issue and Palette Visibility.
[IMPROVEMENT] Improved styles and colors.
Fixed theming issues.
[FIX] Fixed theming for update_avatar_options.xml.
[FIX] Fixed theming issues in ChatRoomFragment.kt
[FIX] Fixed theming issues with message attachments.
[FIX] Fixed theming issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROJECT: THEME SUPPORT FOR ROCKET.CHAT ANDROID APP
Requirement:
Themes are very popular and they are part of what makes Android stand out from the rest. But the current Rocket.Chat Android app lacks the feature of applying different themes. This project aims to bring different themes support like dark mode and black mode into the existing Android client. It should enable any developer to create a theme for the Rocket.Chat Android app without the need to work with our core codebase.
Student:
Noor Binte Amir
Organization:
Rocket.Chat
Mentors:
Deliverables:
Theme Engine
Built In Themes
The theme engine comes with a theme library with three built-in themes to choose from.
Custom Themes
This feature allows you to edit any of the app's built-in themes and save it as a new custom theme.
Documentation:
User Guide:
https://github.com/NBAMIR/docs/blob/nbamir-themes/user-guides/themes/android/README.md
Developer Guide:
https://github.com/NBAMIR/docs/blob/nbamir-themes/developer-guides/themes/android/README.md
Documentation PR:
https://github.com/RocketChat/docs/pull/1395