-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed UI issues for Sidebar #634
base: develop
Are you sure you want to change the base?
Conversation
@Spiral-Memory do I need to test it on some more cases ? |
Really loved the thorough testing done by you in the attached video, I'll review the PR and test myself once and let you know. Thank you so much for your contribution ❤️ |
Once go to design variants, modern design and check if popup mode is working fine after this change and attach a video |
I've attached the popup mode video , |
Hey @Spiral-Memory , are any more tests required ? |
I haven't tested it yet, let the pr preview auto deployment feature get implemented, afterwards, I'll test and let you know if any changes are required |
775f8fd
to
4bd0e53
Compare
Hey @abirc8010, I noticed two issues. Please fix them:
|
To fix this issue, I have to add resize event listener , will that be ok ? |
But why do we need listeners ? Why can't we use media queries to handle it properly ? |
The Sidebar component accepts a style prop in the form of a css object, which makes it difficult to implement media queries effectively. That's why I am considering using a resize event listener instead . |
It is not recommended to use event listeners in this use case. Try using only media queries. You can still write the CSS in the style.js file and pass it. Try to figure out a solution using media queries. |
@Spiral-Memory , I have fixed the issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach seems fine; you are trying to add it to the global styles. However, why can't we add similar media queries and pass them directly to the sidebars, without overriding class styles globally?
As far as I'm aware, you can set media queries in a style object as well, or try using the css attribute with Emotion/React. I'll have to look into it to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to test !
Could you please check, if we can use media queries in style object ?. |
Hey @Spiral-Memory , I fixed the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to test !
@Spiral-Memory do I need to make any changes? |
Brief Title
This PR fixes UI issues for Sidebar making it responsive
Acceptance Criteria fulfillment
Fixes # (issue)
#629
Video/Screenshots
Screencast.from.2024-10-02.02-07-54.webm
Popup Mode:
popup.webm
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-634 after approval.