Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auton #12
base: master
Are you sure you want to change the base?
Auton #12
Changes from all commits
d4de5bf
a7530f7
c16f84b
81d7450
64d77ea
8ba0ee3
92f22cb
d0a3fa7
564d95e
dee813c
4466882
106a003
54c8acb
6b5a38a
b3ff845
d7c2cda
8185448
3a82edb
318cd2e
1b61489
f2f24ba
fd35775
b098fdf
2e68936
9727dca
f750125
6ca06fc
5fbf836
36f80d8
5d4a445
ff2600f
45fcf39
65f1d1f
b2c3342
8a306f5
895f2c3
b7ac2bc
eafdff7
04a80f1
f39b159
0d5bedd
b956594
767e994
034fabb
ee2665d
0a9461b
5dc651d
8e223de
63d5b08
85e69d0
66c8cc9
6dadfb2
d4458bc
17df07d
e610193
6fbbdb4
d4a2bf9
d26112e
ec6fa20
b09f3dd
76515c2
a591654
f0f2fea
04d632a
0add219
85ea206
9ca9c14
0f9774c
a2ef756
f1399b4
57a0820
b149f32
293135e
dd60f57
e5293ea
36be9a9
a3a9b4b
71f93ee
8d55876
5031ff9
2e7b1ef
b7662ef
3641b6d
0c8b623
c64525f
7a8aa78
34a6c84
e7e80fb
ac2b12e
020561a
5140151
d65e063
718d895
54db0c6
786b8ba
562fcfa
42d1161
71d14c9
5d00d49
9199fac
a4400e9
7dd93c7
8c26308
82a00dd
765431d
8334927
93b6615
e8ea71e
eef31be
7afe928
d51fca0
bcc5734
80fb3d9
c18d4df
0f89bc4
2aab342
db3ad4a
95cdc0d
194acc4
224b613
9f97d4f
e73a009
1e2d750
cee2607
f272320
f451114
bca1faf
8855352
85e7705
636a8e5
7b083bf
d306139
a231d2d
9e3ad13
bc66eba
65f8a40
abab9ab
94a6806
fde0fc1
8e74e4f
c6746fb
0a9e16b
1fde7ab
c3f92ac
0483f61
e387fc6
a379fb1
c271289
b3e2c25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be mistaken, but doesn't andThen require you to already have some commands in the group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you do instead to add the first command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just use
SimpleSplines
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to if the robot is just moving forwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe clarify that this is
PickupAndShootCenter
, where we don't reevaluate our position.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean that it doesn't use localization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar comments to
PickupAndShootCenter
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using
andThen
, you can use theaddCommands
method and pass in all your commands in orderThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not gonna bother with checking all of these constants right now, but just remember that - is right and clockwise, + is left and ccw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah most of these are probably wrong, especially the rotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing with
addCommands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
addCommands